Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] VarInfo changes #188

Closed
wants to merge 15 commits into from
Closed

[WIP] VarInfo changes #188

wants to merge 15 commits into from

Conversation

mohamed82008
Copy link
Member

@yebai asked me to open a PR with the MixedVarInfo work from the neurips submission so here it is. This PR is not compatible at all with the current DPPL and Turing, so please don't review it seriously. It will need some significant changes to make it up to date but it might be useful in today's meeting.

@yebai
Copy link
Member

yebai commented Nov 16, 2020

Many thanks, @mohamed82008 for creating this PR. I suggest that we consider extracting the changes related to AbstractVarInfo into a new PR, and get that merged as the first step. Focusing on AbstractVarInfo would allow us to focus on the core API and functionality, significantly reducing the workload for the first PR and paving the way for other VarInfo subtypes, e.g. MixedVarInfo. This also allows the team to carefully review the AbstractVarInfo and provide useful feedback along the process.

cc @devmotion @phipsgabler

@yebai
Copy link
Member

yebai commented Dec 16, 2021

Closed in favour of #351. MixedVarInfo can be replaced with a combination of SimpleVarInfo{NamedTuple} and SimpleVarInfo{Dict}.

@yebai yebai closed this Dec 16, 2021
@yebai yebai deleted the mt/neurips branch December 16, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants